Attention is currently required from: lynxis lazus.

View Change

4 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 1284: "allow-bts-configuration <0-65535>",

    Unfortunately we have a mix of two different command styles: a) 'COMMAND <0-255>' and b) 'bts <0-255> COMMAND'. Personally I find b) more logical and suggest to use it for the new command. For example, see bts_resend_sysinfo_cmd.

  • Patch Set #1, Line 1284: 65535

    Not sure if OML allows to address more than 256 BTS instances, but ok.

  • Patch Set #1, Line 3087: bts ramp limit

    I suggest to rework this command as follows:

      bts-ramp          # "Configure BTS ramping parameters\n"
      limit <0-999>     # "Limit number of BTS\n" "Number of BTS\n"
      window <0-999>    # "Time window\n" "Time window (in seconds)\n"

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #1, Line 92: struct gsm_bts *bts,

    weird [mis]alignment

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.