Attention is currently required from: msuraev.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30683 )
Change subject: SMPP: refactor ref counting code
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/30683/comment/e8f78c6e_456a0fa3
PS1, Line 9: single-use static function to simplify
What's wrong with having this static function? The compiler will highly likely inline
it anyway. From the symbol naming perspective, I think it's fine to keep it in a
separate function with self-explaining name. Especially if someone will need to destroy an
esme immediately some day.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30683
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9cb530991f54aa78edaa885f1242f63c705b6fcb
Gerrit-Change-Number: 30683
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Dec 2022 19:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment