Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 )
Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ......................................................................
Patch Set 5:
(3 comments)
File src/osmo-bsc/neighbor_ident_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/d25222c7_7566934d PS3, Line 107: struct osmo_strbuf csv = { .buf = log_buf,
what does csv stand for?
comma separated value. I changed it to 'reply', hope that's better
https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/70b4e1bf_7dddd11f PS3, Line 109: .pos = log_buf,
grepping for "struct osmo_strbuf" in osmocom code shows all users only set .buf and . […]
Without initializing `.pos`, the code breaks in case `OSMO_STRBUF_PRINTF` is never called. I have removed the line `.chars_needed`.
https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/70d5efdf_55148b73 PS3, Line 118: llist_for_each_entry(n, &bts->neighbors, entry) {
This is not correct to my understanding. […]
Hmm alright. In the issue, Christian Balzano wrote a very specific example where the numbers of BTSs from the .cfg where printed without mentioning any others.
I have adapted the patch to print all BTS numbers of BTSs that are configured locally and added a testcase checking on BTSs configured via CGI-PS, as well.