Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/neighbor_ident_ctrl.c:

  • Patch Set #3, Line 107: struct osmo_strbuf csv = { .buf = log_buf,

    what does csv stand for?

    comma separated value. I changed it to 'reply', hope that's better

  • Patch Set #3, Line 109: .pos = log_buf,

    grepping for "struct osmo_strbuf" in osmocom code shows all users only set .buf and . […]

    Without initializing `.pos`, the code breaks in case `OSMO_STRBUF_PRINTF` is never called. I have removed the line `.chars_needed`.

  • Patch Set #3, Line 118: llist_for_each_entry(n, &bts->neighbors, entry) {

    This is not correct to my understanding. […]

    Hmm alright. In the issue, Christian Balzano wrote a very specific example where the numbers of BTSs from the .cfg where printed without mentioning any others.

    I have adapted the patch to print all BTS numbers of BTSs that are configured locally and added a testcase checking on BTSs configured via CGI-PS, as well.

To view, visit change 30982. To unsubscribe, or for help writing mail filters, visit settings.