Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 )
Change subject: library/RSL_Types: RSL_SpeechAlgo: support CSD ......................................................................
Patch Set 4:
(4 comments)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/5db99e84_8a54c... PS4, Line 874: mode.u.speech Be careful here. Unions in TTCN-3 (unlike unions in C) throw an error if you're trying to access a different variant than the one that was chosen. I recommend doing this:
if (ischosen(mode.u.speech) and mode.u.speech == RSL_CMOD_SP_GSM3)
or alternatively (we may want a template for this):
if (match(mode.u, RSL_ChanModeOct6:{ speech := RSL_CMOD_SP_GSM3 })
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/7c224d82_8478d... PS4, Line 2545: g_pars.chan_mode.u.sign == RSL_CMOD_NO_RESOURCE `if (ischosen(g_pars.chan_mode.u.sign)) ...`
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/09039cf2_67a2c... PS4, Line 2547: else `else if (ischosen(g_pars.chan_mode.u.speech)) ...`
File bts/BTS_Tests_VAMOS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/7c03536b_3137b... PS4, Line 177: chan_mode.u.speech same here, check `ischosen()` before accessing or match with a template