Attention is currently required from: osmith, laforge, pespin.

4 comments:

File bts/BTS_Tests.ttcn:
- Patch Set #4, Line 874: mode.u.speech
  Be careful here. Unions in TTCN-3 (unlike unions in C) throw an error if you're trying to access a different variant than the one that was chosen. I recommend doing this:
```
  if (ischosen(mode.u.speech) and mode.u.speech == RSL_CMOD_SP_GSM3)
```
  or alternatively (we may want a template for this):
```
  if (match(mode.u, RSL_ChanModeOct6:{ speech := RSL_CMOD_SP_GSM3 })
```
- Patch Set #4, Line 2545: g_pars.chan_mode.u.sign == RSL_CMOD_NO_RESOURCE
  `if (ischosen(g_pars.chan_mode.u.sign)) ...`
- Patch Set #4, Line 2547: else
  `else if (ischosen(g_pars.chan_mode.u.speech)) ...`
File bts/BTS_Tests_VAMOS.ttcn:
- Patch Set #4, Line 177: chan_mode.u.speech
  same here, check `ischosen()` before accessing or match with a template

To view, visit change 31556. To unsubscribe, or for help writing mail filters, visit settings.