Attention is currently required from: clufn, laforge.
pespin has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 and IPv4v6 support ......................................................................
Patch Set 6:
(1 comment)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/b0c3db8e_58bf1... : PS5, Line 136: ipv6 = remove_prefix(Addr)};
3GPP TS 29.274 Table 8.14-1: PDN Address Allocation, […]
Ok, so IIUC you are removing the "IPv6 Prefix Length" byte, not an ipv6 prefix. Please update the naming accordingly and add the spec reference to the function.
%% Remove "IPv6 Prefix Length" from PAA (3GPP TS 29.274 Table 8.14). remove_v6_prefix_len_byte(<<A:8, Rest/binary>>) when is_binary(Rest) -> Rest.