Attention is currently required from: clufn, laforge.
View Change
1 comment:
File src/conv.erl:
Patch Set #5, Line 136: ipv6 = remove_prefix(Addr)};
3GPP TS 29.274 Table 8.14-1: PDN Address Allocation, […]
Ok, so IIUC you are removing the "IPv6 Prefix Length" byte, not an ipv6 prefix.
Please update the naming accordingly and add the spec reference to the function.
%% Remove "IPv6 Prefix Length" from PAA (3GPP TS 29.274 Table 8.14).
remove_v6_prefix_len_byte(<<A:8, Rest/binary>>) when is_binary(Rest) ->
Rest.
To view, visit change 40255. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 6
Gerrit-Owner: clufn <callumfarrbennett@yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: clufn <callumfarrbennett@yahoo.com>
Gerrit-Comment-Date: Thu, 08 May 2025 10:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: clufn <callumfarrbennett@yahoo.com>