Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40684?usp=email )
Change subject: xua: Introduce internal APIs to transmit DAUD
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40684/comment/f6174f4c_5bca8…
:
PS2, Line 988: /* encoding is exactly identical to DUNA */
I'd drop that comment here, given that it isn't calling m3ua_encode_duna,
xua->hdr.msg_type is different and the same note is already in m3ua_encode_daud.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40684?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iab6126f1a9eac1a66bb8ec362b87e20a5eb795ff
Gerrit-Change-Number: 40684
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jul 2025 07:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes