Attention is currently required from: pespin.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/m3ua.c:
Patch Set #2, Line 988: /* encoding is exactly identical to DUNA */
I'd drop that comment here, given that it isn't calling m3ua_encode_duna, xua->hdr.msg_type is different and the same note is already in m3ua_encode_daud.
To view, visit change 40684. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iab6126f1a9eac1a66bb8ec362b87e20a5eb795ff
Gerrit-Change-Number: 40684
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jul 2025 07:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes