12 May
2025
12 May
'25
11:37 a.m.
Attention is currently required from: clufn.
pespin has posted comments on this change by clufn. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email )
Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2
PDN Address Allocation
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/72f91d69_e8f9…
:
PS1, Line 140: #v2_pdn_address_allocation{type = ipv4v6, address =
get_v4v6(maps:get(ipv4,Address),maps:get(ipv6,Address))}.
missing space between parameters. Several times in lines 135-140.
File src/epdg_ue_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/31980744_b166…
:
PS1, Line 264: Data1 = Data#ue_fsm_data{paa =
conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},
I'd really prefer keeping the pdp address in our own format and only convert o gtp2
struct whenever passing it to gtp2 code.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/bb3beb7e_3612…
:
PS1, Line 353: Data#ue_fsm_data.paa,
"conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress)" here, or even better, do
it inside epdg_gtpc_s2b:create_session_req()
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: If0c77b1e366df36439d3a1b72030d831dd1b3a05
Gerrit-Change-Number: 40277
Gerrit-PatchSet: 1
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Comment-Date: Mon, 12 May 2025 09:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes