Attention is currently required from: clufn.

Patch set 1:Code-Review -1

View Change

3 comments:

• File src/conv.erl:

  • Patch Set #1, Line 140: #v2_pdn_address_allocation{type = ipv4v6, address = get_v4v6(maps:get(ipv4,Address),maps:get(ipv6,Address))}.

    missing space between parameters. Several times in lines 135-140.

• File src/epdg_ue_fsm.erl:

  • Patch Set #1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},

    I'd really prefer keeping the pdp address in our own format and only convert o gtp2 struct whenever passing it to gtp2 code.

  • Patch Set #1, Line 353: Data#ue_fsm_data.paa,

    "conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress)" here, or even better, do it inside epdg_gtpc_s2b:create_session_req()

To view, visit change 40277. To unsubscribe, or for help writing mail filters, visit settings.