[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

Attention is currently required from: osmith, pespin, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Patch Set 8: (5 comments) File src/alloc_algo.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/79bcab0e_99e8bfe3 PS8, Line 761: memset(res->usf, -1, sizeof(res->usf)); Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. This will likely work for `-1`, because it's basically `0xffffffff`, but doing e.g. `memset(res->usf, 1, sizeof(res->usf))` will result in 0x1010101 being written to each array item. Not critical, but I would rather avoid it for the good and init using a for-loop. https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/52a151b4_fee57e13 PS8, Line 800: res->usf `&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then you go and check the `struct alloc_resources_res` and figure out that it's actually an array. https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/db65f286_12d78ead PS8, Line 863: struct alloc_resources_res *res) coemstic: alignment File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/ce86fd5d_0847d22d PS7, Line 588: Done File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/47086095_3df413cf PS8, Line 720: %u `%d` because it's int? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 20:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment