Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38635?usp=email )
Change subject: global_platform/scp: refactor _wrap_cmd_apdu ......................................................................
Patch Set 1:
(2 comments)
File pySim/global_platform/scp.py:
https://gerrit.osmocom.org/c/pysim/+/38635/comment/7d232cc8_2bd6f256?usp=ema... : PS1, Line 279: if self.do_cmac: Adding another indention level does not make functions more readable either...
Maybe do an early return?
``` if not self.do_cmac: return apdu ```
https://gerrit.osmocom.org/c/pysim/+/38635/comment/f6535e88_3a633a76?usp=ema... : PS1, Line 482: if self.do_cmac: Likewise, maybe do an early return?
``` if not self.do_cmac: return apdu ```