Attention is currently required from: arehbein, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )
Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5: Proposal: - implementation of osmo_stream should always use iofd, hence the old implementation is dropped (or #if 0 or ENV disabled for now). - the old _create() functions with read_cb and close_cb are kept for backward compat - a new _create() function is added, which has no read_cb nor close_cb, but a const char *name. - Separate APIs are added to set the new iofd_read_cb and iofd_close_cb. - Internally, the osmo_stream code calls the read_cb() if non NULL, or/and the iofd_read_cb() if not NULL (the only difference afaiu is the extra msg ptr being passed).
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/4bf8852b_01fcb000 PS5, Line 1197: static int osmo_stream_srv_ofd_cb(struct osmo_fd *ofd, unsigned int what) I'd welcome if you did this kind of changes in separate previous patches to try to trim this one a bit so we can focus on how to add iofd in here.