Attention is currently required from: arehbein, daniel.

View Change

2 comments:

• Patchset:

  • Patch Set #5:

    Proposal:

    • implementation of osmo_stream should always use iofd, hence the old implementation is dropped (or #if 0 or ENV disabled for now).
    • the old _create() functions with read_cb and close_cb are kept for backward compat
    • a new _create() function is added, which has no read_cb nor close_cb, but a const char *name.
    • Separate APIs are added to set the new iofd_read_cb and iofd_close_cb.
    • Internally, the osmo_stream code calls the read_cb() if non NULL, or/and the iofd_read_cb() if not NULL (the only difference afaiu is the extra msg ptr being passed).

• File src/stream.c:

  • Patch Set #5, Line 1197: static int osmo_stream_srv_ofd_cb(struct osmo_fd *ofd, unsigned int what)

    I'd welcome if you did this kind of changes in separate previous patches to try to trim this one a bit so we can focus on how to add iofd in here.

To view, visit change 33193. To unsubscribe, or for help writing mail filters, visit settings.