Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email )
Change subject: stream_srv: Fix connection error handling ......................................................................
Patch Set 2:
(2 comments)
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/51457438_4e5307f5 PS1, Line 489: if (res <= 0) {
OSMO_UNLIKELY()
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/3efda64c_aa233bdb PS1, Line 493: if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {
so if iofd_read_cb is not sent you won't destroy the conn? this looks wrong?
You're right, thanks! It's also leaking msg if iofd_read_cb is not set, though I'm unsure how common/useful an osmo_stream_srv without a read callback even is.