Attention is currently required from: pespin.

View Change

2 comments:

• File src/stream_srv.c:

  • Patch Set #1, Line 489: if (res <= 0) {

    OSMO_UNLIKELY()

    Done

  • Patch Set #1, Line 493: if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {

    so if iofd_read_cb is not sent you won't destroy the conn? this looks wrong?

    You're right, thanks! It's also leaking msg if iofd_read_cb is not set, though I'm unsure how common/useful an osmo_stream_srv without a read callback even is.

To view, visit change 34338. To unsubscribe, or for help writing mail filters, visit settings.