Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 )
Change subject: pgw: Initial Gy support ......................................................................
Patch Set 3:
(1 comment)
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/a09ec15e_8808c... PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
I see no point in doing so. I think it's actually perfect to do it this way.
Well, I generally don't like that f_shutdown() is overloaded with setting a verdict. IMO this function should do what its name suggests: shutdown everything. There is already a language construct for setting a verdict (which btw supports argument concatenation), so we should stick to a single approach.