Attention is currently required from: pespin.
View Change
1 comment:
File pgw/PGW_Tests.ttcn:
Patch Set #2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
I see no point in doing so. I think it's actually perfect to do it this way.
Well, I generally don't like that f_shutdown() is overloaded with setting a verdict. IMO this function should do what its name suggests: shutdown everything. There is already a language construct for setting a verdict (which btw supports argument concatenation), so we should stick to a single approach.
To view, visit change 27853. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f
Gerrit-Change-Number: 27853
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Apr 2022 11:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment