Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41920?usp=email )
Change subject: saip SmspTpScAddr: safeguard against decoding error ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/41920/comment/59eda287_eb94a4c9?usp=ema... : PS2, Line 13: The underlying issue, I presume, is that either the data needs : validation before decode_record_bin(), or decode_record_bin() needs : well-defined error handling. I'm not sure why raising an exception on a parsing error is not considered well-defined? Isn't that the normal/expected behaviour if some input data doesn't parse?
I think we have the following situations: * file contains something specified by 3GPP/ETSI specs for the given file: should not raise exception and instead return a value; "None" in case of an empty value * file contains something unexpected/unforseen by 3GPP/ETSI specs for the given file: exception makes sense