Attention is currently required from: neels.

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 13:

    The underlying issue, I presume, is that either the data needs
    validation before decode_record_bin(), or decode_record_bin() needs
    well-defined error handling.
    

    I'm not sure why raising an exception on a parsing error is not considered well-defined? Isn't that the normal/expected behaviour if some input data doesn't parse?

    I think we have the following situations:

    • file contains something specified by 3GPP/ETSI specs for the given file: should not raise exception and instead return a value; "None" in case of an empty value
    • file contains something unexpected/unforseen by 3GPP/ETSI specs for the given file: exception makes sense

To view, visit change 41920. To unsubscribe, or for help writing mail filters, visit settings.