Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email )
Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/mgcp_client/mgcp_client.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/cf48a865_e1b16b96 PS2, Line 121: struct mgcp_msg {
Can you point me to the API allocating and returning a pointer to this struct? because I cannot find […]
The reason for this is that mgcp_client_fsm.c is using it. So it's in deed not so private as I thought. I also remember now we were indeed using it in osmo-bsc before we had the mgcp_client_fsm and mgcp_client_endpoint_fsm API.
I guess this also means that we might need an alloc function for it?
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/4f653945_eb0f285d PS2, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n");
You marked as DONE but I see no change...
That is strange. I hope you see the update now...