Attention is currently required from: pespin.

View Change

2 comments:

• File include/osmocom/mgcp_client/mgcp_client.h:

  • Patch Set #2, Line 121: struct mgcp_msg {

    Can you point me to the API allocating and returning a pointer to this struct? because I cannot find […]

    The reason for this is that mgcp_client_fsm.c is using it. So it's in deed not so private as I thought. I also remember now we were indeed using it in osmo-bsc before we had the mgcp_client_fsm and mgcp_client_endpoint_fsm API.

    I guess this also means that we might need an alloc function for it?

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #2, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n");

    You marked as DONE but I see no change...

    That is strange. I hope you see the update now...

To view, visit change 34351. To unsubscribe, or for help writing mail filters, visit settings.