Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email )
Change subject: stream: Fix build with --disable-libsctp ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/be35e17d_4a578ecf... : PS1, Line 7: stream: make SCTP usage conditional on HAVE_LIBSCTP
I think this patch you be named instead: […]
Agreed, renamed to "stream: Fix build with --disable-libsctp".
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/c0e3e582_20f494dc... : PS1, Line 53: #include <osmocom/netif/sctp.h>
You can actually simply move this below inside the ifdef in line 58.
Done, moved it inside the `#ifdef HAVE_LIBSCTP` as suggested.
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/5fe214dd_eaffd06a... : PS1, Line 1273: local_addrcnt = cli->local_addrcnt;
You could do […]
Done, refactored as suggested to reduce the `#ifdef HAVE_LIBSCTP` block.
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/06ce6b13_78d6fc45... : PS1, Line 1050: #ifdef HAVE_LIBSCTP
#ifdef HAVE_LIBSCTP […]
Done, refactored as suggested.