Attention is currently required from: pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: stream: make SCTP usage conditional on HAVE_LIBSCTP

    I think this patch you be named instead: […]

    Agreed, renamed to "stream: Fix build with --disable-libsctp".

• File src/stream.c:

  • Patch Set #1, Line 53: #include <osmocom/netif/sctp.h>

    You can actually simply move this below inside the ifdef in line 58.

    Done, moved it inside the `#ifdef HAVE_LIBSCTP` as suggested.

• File src/stream_cli.c:

  • Patch Set #1, Line 1273: local_addrcnt = cli->local_addrcnt;

    You could do […]

    Done, refactored as suggested to reduce the `#ifdef HAVE_LIBSCTP` block.

• File src/stream_srv.c:

  • Patch Set #1, Line 1050: #ifdef HAVE_LIBSCTP

    #ifdef HAVE_LIBSCTP […]

    Done, refactored as suggested.

To view, visit change 41952. To unsubscribe, or for help writing mail filters, visit settings.