[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

Attention is currently required from: csaba.sipos, pespin. fixeria has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 6: (3 comments) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d1750954_c4a3d22e?usp… : PS6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type, I guess you mean the existing per-`TS_NODE` commands for setting hopping params? What kind of integration you're suggesting? I can only think of adding a generic command that would not be Nokia *Site specific. https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/a6f63eba_ae52f4a5?usp… : PS6, Line 470: nokia_hopping Maybe call this part `hopping-kind` or `hopping-mode`? Also, I don't like the choice of numeric modes (`0` and `1`), making it less obvious. I suggest using string literals instead: ``` nokia_site hopping-mode (baseband|synth) ``` https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/c50289ac_4c82ba7f?usp… : PS6, Line 474: CMD_ATTR_IMMEDIATE Are you sure about the immediate effect? I doubt it applies to a working BTS immediately. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 10:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>