Attention is currently required from: csaba.sipos, pespin.
fixeria has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email )
Change subject: nokia_site: introduce hopping control for Nokia *Site ......................................................................
Patch Set 6:
(3 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d1750954_c4a3d22e?usp=... : PS6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type,
... existing hopping support already in osmo-bsc.
I guess you mean the existing per-`TS_NODE` commands for setting hopping params? What kind of integration you're suggesting? I can only think of adding a generic command that would not be Nokia *Site specific.
https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/a6f63eba_ae52f4a5?usp=... : PS6, Line 470: nokia_hopping Maybe call this part `hopping-kind` or `hopping-mode`? Also, I don't like the choice of numeric modes (`0` and `1`), making it less obvious. I suggest using string literals instead:
``` nokia_site hopping-mode (baseband|synth) ```
https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/c50289ac_4c82ba7f?usp=... : PS6, Line 474: CMD_ATTR_IMMEDIATE Are you sure about the immediate effect? I doubt it applies to a working BTS immediately.