Attention is currently required from: csaba.sipos, pespin.

View Change

3 comments:

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type,

    ... existing hopping support already in osmo-bsc.

    I guess you mean the existing per-`TS_NODE` commands for setting hopping params? What kind of integration you're suggesting? I can only think of adding a generic command that would not be Nokia *Site specific.

  • Patch Set #6, Line 470: nokia_hopping

    Maybe call this part `hopping-kind` or `hopping-mode`? Also, I don't like the choice of numeric modes (`0` and `1`), making it less obvious. I suggest using string literals instead:

    ```
    nokia_site hopping-mode (baseband|synth)
    ```

  • Patch Set #6, Line 474: CMD_ATTR_IMMEDIATE

    Are you sure about the immediate effect?
    I doubt it applies to a working BTS immediately.

To view, visit change 39290. To unsubscribe, or for help writing mail filters, visit settings.