pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/26717 )
Change subject: amr: Introduce APIs to convert BE to IuUP/IuFP format
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/libosmo-netif/+/26717/2/src/amr.c
File src/amr.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/26717/2/src/amr.c@264
PS2, Line 264: int i;
Consistency with osmo_amr_bwe_to_iuup(): unsigned.
It doesn't need to be consistent because the loop is totally different. In any
case, I uses int i here because I initially whent up to 0 when writting it,and I wanted to
avoid a similar bug to the one I recently introduced :)
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/26717
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd32d5f2060abe581730996dc4251381bf7d4f
Gerrit-Change-Number: 26717
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jan 2022 13:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment