View Change
1 comment:
File src/amr.c:
Patch Set #2, Line 264: int i;
Consistency with osmo_amr_bwe_to_iuup(): unsigned.
It doesn't need to be consistent because the loop is totally different. In any case, I uses int i here because I initially whent up to 0 when writting it,and I wanted to avoid a similar bug to the one I recently introduced :)
To view, visit change 26717. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd32d5f2060abe581730996dc4251381bf7d4f
Gerrit-Change-Number: 26717
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jan 2022 13:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment