Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 )
Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ......................................................................
Patch Set 7:
(1 comment)
File src/fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/1f3d90b6_861c25bb PS7, Line 296: "state name '%s'\n", states[i].name);
I think this is problematic. osmo_fsm_register() may be called before the log is set up. […]
I think we should rather make sure that our logging subsystem does something useful (and not assert) if log output is generated before the log subsystem configuration is initialized. This has been hurting us over and over again.