Attention is currently required from: dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/16355 )
Change subject: osmo_fsm: Ensure all state and event names are valid identifiers
......................................................................
Patch Set 7:
(1 comment)
File src/fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/1f3d90b6_861c25bb
PS7, Line 296: "state name '%s'\n", states[i].name);
I think this is problematic. osmo_fsm_register() may
be called before the log is set up. […]
I think we should rather make sure that our
logging subsystem does something useful (and not assert) if log output is generated before
the log subsystem configuration is initialized. This has been hurting us over and over
again.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/16355
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jan 2022 14:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment