Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 )
Change subject: trxcon: rework L1CTL socket API to support multiple clients ......................................................................
Patch Set 4:
(3 comments)
File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/8fc6275a_1fac43c7 PS4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */ Did you think about adding an .ops struct?
https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/0d5c5e48_9b3d4d36 PS4, Line 35: struct llist_head list; document where is this item added to. struct l1ctl_server "clients" I guess?
File src/host/trxcon/src/l1ctl_link.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/f7ea8b7d_116c40fb PS4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags) this new function name is misleading imho. I'd leave it as link or server, since you are operating on the fd of a server.
l1ctl_server_conn_accept.