Attention is currently required from: fixeria.

View Change

3 comments:

• File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:

  • Patch Set #4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */

    Did you think about adding an .ops struct?

  • Patch Set #4, Line 35: struct llist_head list;

    document where is this item added to. struct l1ctl_server "clients" I guess?

• File src/host/trxcon/src/l1ctl_link.c:

  • Patch Set #4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags)

    this new function name is misleading imho.
    I'd leave it as link or server, since you are operating on the fd of a server.

    l1ctl_server_conn_accept.

To view, visit change 28669. To unsubscribe, or for help writing mail filters, visit settings.