Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email )
Change subject: s2b: when socket opening fails, stop the S2b module ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/85208e2d_632e0... : PS3, Line 150: io_lib:format Not sure why would you want to include a formatted string here, given that above you're already logging an error. Returning `{udp_socket_open_failed, Reason}` looks more practical to me, but even this feels redundant... The question is, who is supposed to consume this pretty-printed string value? Not blocking, just raising a concern.