Attention is currently required from: laforge, lynxis lazus, pespin.

Patch set 3:Code-Review +1

View Change

1 comment:

• File src/epdg_gtpc_s2b.erl:

  • Patch Set #3, Line 150: io_lib:format

    Not sure why would you want to include a formatted string here, given that above you're already logging an error. Returning `{udp_socket_open_failed, Reason}` looks more practical to me, but even this feels redundant... The question is, who is supposed to consume this pretty-printed string value? Not blocking, just raising a concern.

To view, visit change 37901. To unsubscribe, or for help writing mail filters, visit settings.