Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email )
Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/cdd15ca1_9cabcd8f
PS2, Line 1817: /* Do not forward any message from the MS to LAPD while the uplink is
not
This "MS to LAPD" direction description is
not really clear to me. […]
I don't really see the problem here. It might be
worth adding "uplink" to clarify - but the BTS for sure is receiving frames from
the MS and passes them to LAPD, there's nothing ambiguous about it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3
Gerrit-Change-Number: 34423
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Sep 2023 12:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment