Attention is currently required from: fixeria, jolly, pespin.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/common/l1sap.c:
Patch Set #2, Line 1817: /* Do not forward any message from the MS to LAPD while the uplink is not
This "MS to LAPD" direction description is not really clear to me. […]
I don't really see the problem here. It might be worth adding "uplink" to clarify - but the BTS for sure is receiving frames from the MS and passes them to LAPD, there's nothing ambiguous about it.
To view, visit change 34423. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3
Gerrit-Change-Number: 34423
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Sep 2023 12:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment