Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email )
Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
Patchset:
PS5: re-adding the existing +2 before addressing latest feedback
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/41734/comment/232f7996_3416d33c?usp=ema... : PS3, Line 636: def file2pe(self, f: File):
Maybe replace "f" with "file" to make it more uniform to the add_file method?
done.
https://gerrit.osmocom.org/c/pysim/+/41734/comment/b78cd03b_18c57aa1?usp=ema... : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples()
Ah ok. I see. Its intentional. Then option a is probably the preferred one. […]
I added a related check, i.e. we raise an exception if the passed file is not part of the PE's files dict.