Attention is currently required from: dexter, fixeria.

Patch set 5:Code-Review +2

View Change

3 comments:

• Patchset:

  • Patch Set #5:

    re-adding the existing +2 before addressing latest feedback

• File pySim/esim/saip/__init__.py:

  • Patch Set #3, Line 636: def file2pe(self, f: File):

    Maybe replace "f" with "file" to make it more uniform to the add_file method?

    done.

  • Patch Set #3, Line 638: self.decoded[f.pe_name] = f.to_tuples()

    Ah ok. I see. Its intentional. Then option a is probably the preferred one. […]

    I added a related check, i.e. we raise an exception if the passed file is not part of the PE's files dict.

To view, visit change 41734. To unsubscribe, or for help writing mail filters, visit settings.