Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 )
Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/include/osmocom/bb/common/sysinfo.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/72f72c1c_1ef9e268 PS2, Line 74: uint8_t supported;
I do use bool wherever possible too. […]
You are touching code adding new fields, I don't see what's the problem with using bools whenever adding a new bool field.
Using 0 and !0 is not confusing AFTER you spend time figuring out that unsigned integer is actually used as a boolean by looking at how the field is used all over the code.