Attention is currently required from: fixeria.

View Change

1 comment:

• File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

  • Patch Set #2, Line 74: uint8_t supported;

    I do use bool wherever possible too. […]

    You are touching code adding new fields, I don't see what's the problem with using bools whenever adding a new bool field.

    Using 0 and !0 is not confusing AFTER you spend time figuring out that unsigned integer is actually used as a boolean by looking at how the field is used all over the code.

To view, visit change 30812. To unsubscribe, or for help writing mail filters, visit settings.