[S] Change in osmo-ttcn3-hacks[master]: s1gw: test S1GW originated PFCP Heartbeat

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email ) Change subject: s1gw: test S1GW originated PFCP Heartbeat ...................................................................... Patch Set 2: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126/comment/0fb566ad_9127… : PS2, Line 1016: if (mp_rest_enable) { I don't see what's wrong with doing that. How could the same procedure that is specified for both CP and UP functions be a "totally separate thing"? I am not following your concern either. Because periodic sending of PFCP Heartbeat (triggered by a timer) is not yet implemented in OsmoS1GW and triggering it via the REST interface is currently the only way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I28fb46be037a488e225d20a16b83d0479c6e067d Gerrit-Change-Number: 41126 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 11:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>