Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31174 )
Change subject: pcu_l1_if: receive E1 connection parameters ......................................................................
Patch Set 3:
(2 comments)
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/4b564a72_d60a0eef PS1, Line 81: struct gsm_e1_subslot e1_link;
This is inherited from osmo-bsc, there the name e1_link is very common. […]
is inherited by osmo-bsc you mean you are introducing this same problem now in osmo-pcu? I'm not really liking naming variables with different branding that the type.
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/b77eaec4_4704d8db PS1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) {
As far as I know not. The 255 is also used in osmo-bsc:bts_trx_vty.c like this. […]
So we are further spreading the use of hardcoded values. That seems like an argument for defining this somewhere, rather than against doing so.