Attention is currently required from: fixeria, dexter.

View Change

2 comments:

• File src/pcu_l1_if.cpp:

  • Patch Set #1, Line 81: struct gsm_e1_subslot e1_link;

    This is inherited from osmo-bsc, there the name e1_link is very common. […]

    is inherited by osmo-bsc you mean you are introducing this same problem now in osmo-pcu? I'm not really liking naming variables with different branding that the type.

  • Patch Set #1, Line 1003: if (e1_ccu_ind->e1_ts_ss == 255) {

    As far as I know not. The 255 is also used in osmo-bsc:bts_trx_vty.c like this. […]

    So we are further spreading the use of hardcoded values. That seems like an argument for defining this somewhere, rather than against doing so.

To view, visit change 31174. To unsubscribe, or for help writing mail filters, visit settings.