Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email )
Change subject: S1GW: Add test case to test release of e-RABs during handover preperation ......................................................................
Patch Set 3:
(6 comments)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/7ddd48f2_a839f... : PS2, Line 1210: in ERabIdxList erabs_release := {})
For `ERabIdxList`, yes, we don't really need `in/out`. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/17025b7e_7f51f... : PS2, Line 1247: in ERabIdxList erabs_release := {})
I vote for stopping adding more "in" churn :D
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/cf3a35e9_6fd72... : PS2, Line 1720: in ERabIdxList erabs_forward,
Why are you so obsessed with this?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/b79698c9_44299... : PS2, Line 1718: function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id, : ENB_UE_S1AP_ID enb_ue_id, : in ERabIdxList erabs_forward, :
Nitpick: in the existing API, arguments `mme_ue_id` and `enb_ue_id` usually follow `ERabList`/`ERabI […]
Done
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/36a7ea75_68347... : PS2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) {
I see this logic repeated in several places, so I think it's worth having a function in `S1GW_ConnHd […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/bcbe3fa7_39a37... : PS2, Line 912:
tabs vs spaces
Done