Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 )
Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ......................................................................
Patch Set 3:
(1 comment)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/b588dc62_9b10c032 PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n",
exactly, I've just used the conventions of the pre-exisging LOGPLCHAN() macro and the LOGPFN macro. […]
Yeah, that makes sense each alone, but joining them and ending up with one fmt var before logging related params and one afterwards really feels like the wrong decision ;) Not going to block though, feel free to merge or fix later.