Attention is currently required from: laforge, fixeria.
1 comment:
File src/common/measurement.c:
Patch Set #3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n",
exactly, I've just used the conventions of the pre-exisging LOGPLCHAN() macro and the LOGPFN macro. […]
Yeah, that makes sense each alone, but joining them and ending up with one fmt var before logging related params and one afterwards really feels like the wrong decision ;)
Not going to block though, feel free to merge or fix later.
To view, visit change 32087. To unsubscribe, or for help writing mail filters, visit settings.