Change in libosmocore[master]: gsm0808: add logging for some IE encoding errors

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30581 ) Change subject: gsm0808: add logging for some IE encoding errors ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: it's nontrivial to add the first logging to a library (part of a library): Before this patch, gsm0808.c can be used without osmo_log_init(). Starting with this patch, all users must initialize logging. in the context of osmocom, we know that all programs use osmo logging. but do we lose flexibility? category DLGLOBAL is a bad fit, should we add DLBSSAP now? a solution would be an error_cb(), concise error info is provided by the lib, the caller decides how to handle it. should we also add logging and better handling for all other error cases in this file? i'd just leave it as it is... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758 Gerrit-Change-Number: 30581 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Dec 2022 22:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment