Attention is currently required from: fixeria.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    it's nontrivial to add the first logging to a library (part of a library):

    Before this patch, gsm0808.c can be used without osmo_log_init().
    Starting with this patch, all users must initialize logging.
    in the context of osmocom, we know that all programs use osmo logging.
    but do we lose flexibility?

    category DLGLOBAL is a bad fit, should we add DLBSSAP now?

    a solution would be an error_cb(), concise error info is provided by the lib, the caller decides how to handle it.

    should we also add logging and better handling for all other error cases in this file?

    i'd just leave it as it is...

To view, visit change 30581. To unsubscribe, or for help writing mail filters, visit settings.